Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate app-shell with inline styles and templates #9081

Closed
stramel opened this issue Jan 3, 2018 · 8 comments
Closed

generate app-shell with inline styles and templates #9081

stramel opened this issue Jan 3, 2018 · 8 comments
Labels
area: schematics/angular devkit/build-angular:app-shell feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature Issue that requests a new feature help wanted
Milestone

Comments

@stramel
Copy link

stramel commented Jan 3, 2018

Versions

Angular CLI: 1.6.3
Node: 8.9.1
OS: linux x64
Angular: 5.1.2
... animations, common, compiler, compiler-cli, core, forms
... http, language-service, platform-browser
... platform-browser-dynamic, router, service-worker

@angular/cli: 1.6.3
@angular/platform-server: error
@angular-devkit/build-optimizer: 0.0.36
@angular-devkit/core: 0.0.22
@angular-devkit/schematics: 0.0.42
@ngtools/json-schema: 1.1.0
@ngtools/webpack: 1.9.3
@schematics/angular: 0.1.11
@schematics/schematics: 0.0.11
typescript: 2.4.2
webpack: 3.10.0

Desired behavior

It would be nice to be able to use the --inline-styles and --inline-templates flags on the ng generate appShell command. I have all the rest of my app generated with inline templates and styles so it is weird that I can't do that with the app-shell as well.

@clydin clydin added command: generate P5 The team acknowledges the request but does not plan to address it, it remains open for discussion feature Issue that requests a new feature labels Jan 3, 2018
@Brocco
Copy link
Contributor

Brocco commented Jan 8, 2018

This is not a bad idea, thanks for submitting.

@hansl hansl unassigned Brocco Feb 1, 2018
@hansl hansl removed the P5 The team acknowledges the request but does not plan to address it, it remains open for discussion label Feb 1, 2018
@ngbot ngbot bot added this to the Backlog milestone Jan 24, 2019
@Jefiozie
Copy link
Contributor

hi @alan-agius4 , is this something still needed/ nice to be added to the schematics? If so would we like to have display-block also added to the list next to inline-template and inline-styles

@alan-agius4
Copy link
Collaborator

I am inclining towards leaving this out for the following reasons;

  1. You can configure these options in the in the angular.json.
  2. Community demand/response has been very low for this.
  3. Increasing code complexity and API surface.
  4. Unlike a component an app-shell is only generated one time, and hence It's trivial to change.

@Jefiozie
Copy link
Contributor

Jefiozie commented Feb 23, 2021

Okay, then I will leave the ticket as it is thanks for responding, should we close the issue?

@angular-robot angular-robot bot added the feature: votes required Feature request which is currently still in the voting phase label Feb 1, 2022
@angular-robot
Copy link
Contributor

angular-robot bot commented Feb 1, 2022

Just a heads up that we kicked off a community voting process for your feature request. There are 20 days until the voting process ends.

Find more details about Angular's feature request process in our documentation.

@ngbot ngbot bot modified the milestones: Backlog, needsTriage Feb 1, 2022
@angular-robot
Copy link
Contributor

angular-robot bot commented Feb 21, 2022

Thank you for submitting your feature request! Looks like during the polling process it didn't collect a sufficient number of votes to move to the next stage.

We want to keep Angular rich and ergonomic and at the same time be mindful about its scope and learning journey. If you think your request could live outside Angular's scope, we'd encourage you to collaborate with the community on publishing it as an open source package.

You can find more details about the feature request process in our documentation.

@angular-robot angular-robot bot added feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors and removed feature: votes required Feature request which is currently still in the voting phase labels Feb 21, 2022
@alan-agius4
Copy link
Collaborator

Closing due to lack of interest from the community for this feature. Let's re-consider if things change.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jun 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: schematics/angular devkit/build-angular:app-shell feature: insufficient votes Label to add when the not a sufficient number of votes or comments from unique authors feature Issue that requests a new feature help wanted
Projects
None yet
Development

No branches or pull requests

8 participants