Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ng xi18n support for source code strings #16943

Closed
1 of 15 tasks
jaska45 opened this issue Feb 11, 2020 · 4 comments
Closed
1 of 15 tasks

Add ng xi18n support for source code strings #16943

jaska45 opened this issue Feb 11, 2020 · 4 comments
Labels
area: devkit/build-angular feature Issue that requests a new feature
Milestone

Comments

@jaska45
Copy link

jaska45 commented Feb 11, 2020

馃殌 Feature request

ng xi18n should also extract strings from the source code files.

Command (mark with an x)

  • new
  • build
  • serve
  • test
  • e2e
  • generate
  • add
  • update
  • lint
  • xi18n
  • run
  • config
  • help
  • version
  • doc

Description

Currently xi18n extracts strings only from templates, not from .ts file. Starting from Angular 9 you can now localize source code string using $localize. However without the extraction support this feature is pretty useless.

Describe the solution you'd like

When I run ng xi18n, it should extract strings from templates and .ts files.

@alan-agius4 alan-agius4 added feature Issue that requests a new feature area: devkit/build-angular labels Feb 12, 2020
@ngbot ngbot bot added this to the Backlog milestone Feb 12, 2020
@alan-agius4
Copy link
Collaborator

//cc @petebacondarwin

@elvisbegovic
Copy link
Contributor

Maybe duplication of feat req angular/angular#11405 and discussion about it/answer is here too angular/angular#16477 (comment)

@alan-agius4
Copy link
Collaborator

Thanks @elvisbegovic you are correct.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Mar 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: devkit/build-angular feature Issue that requests a new feature
Projects
None yet
Development

No branches or pull requests

3 participants