Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SysTick_Handler #184

Open
fiedlfa opened this issue Aug 10, 2016 · 0 comments
Open

SysTick_Handler #184

fiedlfa opened this issue Aug 10, 2016 · 0 comments

Comments

@fiedlfa
Copy link

fiedlfa commented Aug 10, 2016

Hi,

i think you should really not disable the SysTick_Handler by comment it out in the Start-Assembler Code.

/*

  • SysTick_Handler in stm32plus is now marked 'weak' so that compatibility with other

  • frameworks is made possible.

    .weak SysTick_Handler
    .thumb_set SysTick_Handler,Default_Handler
    */

I don't know to which other frameworks you refer but if someone (like me) looks in the original Assembler Code from STM one can miss that you comment it out. If you flash code with the SysTick_Handler to your Stm32 he wants to jump into the SysTick_Handler and doesn't find it and therefor jumps in the WWDG_IRQHandler (either because its the next Handler or its somehow the default one). To find this bug is very tedious.

STM uses in the _it.c (e.g. stm32f10x_it.c) just a empty method as the SysTick_Handler.

I would suggest to do a similar thing. I don't know what's your favorite Version so i didn't file a pull request, but i would probably make a file: config/SysTick_Handler.h which has just the Method:
void SysTick_Handler(void)
{
}

I think this will increase the usability, because also the other way round if i would use a different framework it would be quite difficult to realize the SysTick_Handler is not called because of the Assembler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant