Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PluginGroupConfiguration,PluginGroup,Plugin missed in no.op #293

Open
serhiiLiubetskyiI opened this issue Nov 22, 2023 · 2 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@serhiiLiubetskyiI
Copy link

Describe the bug
PluginGroupConfiguration,PluginGroup,Plugin missed in no.op

To Reproduce
Steps to reproduce the behavior:

  1. Setup no.op for prod build variant
    "prodApi"(libs.plutolib.plugins.bundle.core.no.op)
    "prodApi"(libs.plutolib.pluto.no.op)

  2. Create class with plugins
    class DataSourcePluginGroup : PluginGroup("datasource-group") {
    override fun getConfig() = PluginGroupConfiguration(
    name = "DataSource Group"
    )

    override fun getPlugins(): List {
    return listOf(
    PlutoSharePreferencesPlugin(),
    PlutoDatastorePreferencesPlugin(),
    PlutoRoomsDatabasePlugin()
    )
    }
    }

  3. Add plugin groupe in Pluto
    Pluto.Installer(this)
    .addPlugin(PlutoLoggerPlugin())
    .addPlugin(PlutoNetworkPlugin())
    .addPlugin(PlutoExceptionsPlugin())
    //.addPlugin(PlutoLayoutInspectorPlugin())
    .addPluginGroup(DataSourcePluginGroup())
    .install()

Expected behavior
build variant with no.op should works

image
@serhiiLiubetskyiI serhiiLiubetskyiI added the bug Something isn't working label Nov 22, 2023
@srtvprateek
Copy link
Member

this is happening coz plugin module does not have no-op version, as it did not need it.
the fix for the above issue is to keep your PluginGroup file in variant folder (can refer to the sample app).

let me know if you face any issue in this.

@serhiiLiubetskyiI
Copy link
Author

serhiiLiubetskyiI commented Nov 29, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants