Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RxLogObservable annotation for entire class. #29

Open
VictorAlbertos opened this issue May 27, 2016 · 1 comment
Open

RxLogObservable annotation for entire class. #29

VictorAlbertos opened this issue May 27, 2016 · 1 comment

Comments

@VictorAlbertos
Copy link

Hi Fernando. Thanks for this awesome library :)

I've just integrated it in my current project and it works perfectly. The problem is that I needed to annotation like 50 methods xD

I've annotated every public method for every one of my repositories (and most of their methods have a public visibility). So, I think it will be nice to have an annotation with target ElementType.TYPE in order to be able to annotate an entire class (or repository for that matters), and selecting the methods to be logged based on the visibility scope selected (by default only public).

Do you think this is is technically possible? And if so, would you accept a PR -previously discussing the api?

@android10
Copy link
Owner

Another interesting feedback @VictorAlbertos. Thanks and sorry for the late reply. Will keep this in mind for the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants