Remove loading from screenshot tests #1397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I11c6110d8868bd81836d7bdc031029a867b4dfb0
Change-Id: If82878dee9d4977174dc462157b8e1dcdadaa3c0
Jaehwa-Noh
changed the title
Change-Id: I3878d27af3288500c749137a2cdc809c5f371f35
Change-Id: I95e4c0395f211cce0ea51f47bf876c0dafa6221f
Change-Id: I35fed4ed67d1550080a72a2e977e3b6d48241a47
|
@Jaehwa-Noh, many thanks for the contribution. I was in the process of doing part of this in #1395, and I added the |
|
@JoseAlcerreca I thought you just fix the WorkManager problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I have done and why
The problem is that taken screenshot in loading state.
Besides transparent problem, actually
CircularProgressIndicatorwas so related with time.If taken screenshot after 1 second, screenshot test will fail due to
CircularProgressIndicator's shape.Fixes #1394
How I'm testing it
Choose at least one: