Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Bottom Bar Item is not highlighted in search #1365

Open
3 tasks done
JohannesPtaszyk opened this issue Apr 9, 2024 · 0 comments
Open
3 tasks done

[Bug]: Bottom Bar Item is not highlighted in search #1365

JohannesPtaszyk opened this issue Apr 9, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@JohannesPtaszyk
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Is there a StackOverflow question about this issue?

  • I have searched StackOverflow

What happened?

When opening the search from any backstack, the highlighting of the navigation bar items is gone.

This issue is caused by usage of Destination.hierarchy for highlighting the bottom items.
Currently there is a Library-Restricted field NavHost.currentBackStack, which could be used instead.
Other than that highlighting of global destinations is not really possible, as far as I tried it.

I also found additional sources here:
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:navigation/navigation-runtime/src/main/java/androidx/navigation/NavController.kt;drc=a35c4229c9b7643b15fcd5ddd0d81a7d9abbba4f;l=114

https://issuetracker.google.com/issues/308334893

I also already pinged Ian Lake, to get some answers on why this field is not public API and what would be his suggestion.
https://twitter.com/JPtaszyk/status/1777602817336684829

Relevant logcat output

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@JohannesPtaszyk JohannesPtaszyk added the bug Something isn't working label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant