Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Unsplash] Reenter transition not working edge case #86

Open
thespacemanatee opened this issue Apr 14, 2022 · 0 comments
Open

[Unsplash] Reenter transition not working edge case #86

thespacemanatee opened this issue Apr 14, 2022 · 0 comments

Comments

@thespacemanatee
Copy link

thespacemanatee commented Apr 14, 2022

Hello,

Thank you so much for making this really helpful example. I found an edge case when swiping to images that are not initially visible in the RecyclerView of the source activity:

Working:

  1. When we tap on the first row of images (first 3 images)
  2. Swipe to the last image
  3. Press back to go back to the previous activity, shared element reenter transition works

Demo

video_2022-04-14_15-40-03.mp4

Not Working:

  1. When we tap on any other image
  2. Swipe to the last image
  3. Press back to go back to the previous activity, the shared element reenter transition does not work

Demo

video_2022-04-14_15-40-00.mp4

I thought that perhaps it's because the ViewHolder in the not working example wasn't visible hence the transition mapping won't work, but why does it work when we tap on the first row of images? In any case, how can we fix this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant