Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#47 bugfix javadoc mistake #48

Closed
wants to merge 29 commits into from
Closed

#47 bugfix javadoc mistake #48

wants to merge 29 commits into from

Conversation

LeoAndo
Copy link

@LeoAndo LeoAndo commented Jun 18, 2020

close #47

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@LeoAndo
Copy link
Author

LeoAndo commented Jun 18, 2020

@yaraki @codingjeremy

please review code...

@LeoAndo LeoAndo closed this Jun 18, 2020
@LeoAndo LeoAndo reopened this Jun 18, 2020
@codingjeremy
Copy link
Collaborator

You just need to sign CLA and we can merge.

@codingjeremy codingjeremy changed the base branch from master to main September 29, 2020 18:51
@codingjeremy
Copy link
Collaborator

@LeoAndo Can you sign the CLA? Then I can merge it for you.

Copy link
Member

@yaraki yaraki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you separate the PR for each of the modules?
We can't proceed further unless you sign the CLA.

@@ -61,6 +61,7 @@ protected void onCreate(Bundle savedInstanceState) {

// BEGIN_INCLUDE(detail_set_view_name)
/*
* ここでセットするViewは、遷移元のactivityOptionsで設定したViewとペアであること.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these comments in Japanese.

@LeoAndo
Copy link
Author

LeoAndo commented Oct 28, 2021

I'm sorry. It was reflected in the Pull Request in an unintended way.

pull requestclose it.

@LeoAndo LeoAndo closed this Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

javadoc comments misstake
4 participants