Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Support local non-Git stores #2904

Open
M-u-m-p-i-t-z opened this issue Feb 15, 2024 · 10 comments
Open

[FEATURE] Support local non-Git stores #2904

M-u-m-p-i-t-z opened this issue Feb 15, 2024 · 10 comments
Labels
A-UI-UX Area: General UI/UX concerns C-feature Category: This is a feature request E-hard Effort: This will require a lot of work P-low Priority: low S-design Status: There's a problem here, but no obvious solution; or the solution raises other questions

Comments

@M-u-m-p-i-t-z
Copy link

Is your feature request related to a problem? Please describe.

I don't want to store my passwords online. I do backups only in my local network but not with a git server.
My Phone is not rooted (GrapheneOS) so I also cant import my old 300 password rep.
This new Snapshot build doesnt yet support a local password rep on readable device memory and I cant change the folder like in old F-Droid Version.

Describe the solution you'd like

So may I ask will I get this Feature back? It would be great to use the new version of the app.

Describe alternatives you've considered

an import function is also nice, but my auto backup will not work too because of not readable hidden rep folder.

Additional context

Thank you and greetings!

@M-u-m-p-i-t-z M-u-m-p-i-t-z added C-feature Category: This is a feature request S-awaiting-triage Status: New issues that have not been assessed yet labels Feb 15, 2024
@msfjarvis msfjarvis changed the title [FEATURE] I want my local Password-store back [FEATURE] Support local non-Git stores Feb 15, 2024
@msfjarvis msfjarvis added E-hard Effort: This will require a lot of work P-low Priority: low S-design Status: There's a problem here, but no obvious solution; or the solution raises other questions A-UI-UX Area: General UI/UX concerns and removed S-awaiting-triage Status: New issues that have not been assessed yet labels Feb 15, 2024
@msfjarvis
Copy link
Member

msfjarvis commented Feb 15, 2024

It shouldn't be impossible to support an import flow for files on disk but I personally have no intention of working on this. If someone wants to take it up I'll be more than happy to review a PR.

Edit: I missed the part about having stores in public folders, support for that is not coming back because it severely complicates the code around file handling and I don't want the additional maintenance overhead for a feature I will never use and thus won't receive any testing.

@M-u-m-p-i-t-z
Copy link
Author

Ok thanks anyway, then I have to find another solution. Do you know if I can copy my repo with adb (via wifi) to the hidden folder?
@msfjarvis

@msfjarvis
Copy link
Member

Ok thanks anyway, then I have to find another solution. Do you know if I can copy my repo with adb (via wifi) to the hidden folder? @msfjarvis

You cannot, the only supported solution is Git.

@cprussin
Copy link

Does that mean that there's effectively no way to use the new version of APS with a password store synced via something like Syncthing or some other file sync tool?

@msfjarvis
Copy link
Member

Does that mean that there's effectively no way to use the new version of APS with a password store synced via something like Syncthing or some other file sync tool?

Correct.

@cprussin
Copy link

Ah that's unfortunate. If someone were to want to contribute something back, do you have any suggestion for what to contribute to make that workflow possible? I likely don't have the time or expertise but if I get motivated and you have advice on the right approach, I'll try to give it a shot!

@msfjarvis
Copy link
Member

Ah that's unfortunate. If someone were to want to contribute something back, do you have any suggestion for what to contribute to make that workflow possible? I likely don't have the time or expertise but if I get motivated and you have advice on the right approach, I'll try to give it a shot!

The PasswordRepository class would need an alternate implementation that can properly handle files on external storage, which entails not using java.io.File and replacing it with Storage Access Framework.

@grigorii-horos
Copy link

@M-u-m-p-i-t-z @msfjarvis I need this feature too. I use Sycthing for file sync, and I have a password-store folder in my internal storage, so I want to use this dir in this app.

Now I use the old app, and I can't upgrade it

@msfjarvis
Copy link
Member

That's great, but as I've stated already I have no intention of working on the feature. The only way it gets implemented is by someone contributing it, which I am willing to review and merge.

@mahlonsmith
Copy link

Found this ticket after updating the app, only to have it start crashing because of a lack of a .git repo on my synced password directory.

I've worked around this for now by initializing a git repo on the remote side and letting it sync. This at least makes things usable again, and I'm roughly ignoring the git specifics, though it does feel unnecessarily redundant (for my use case), and a surprise that it was a requirement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-UI-UX Area: General UI/UX concerns C-feature Category: This is a feature request E-hard Effort: This will require a lot of work P-low Priority: low S-design Status: There's a problem here, but no obvious solution; or the solution raises other questions
Projects
None yet
Development

No branches or pull requests

5 participants