Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Passphrase caching requires 2-5 biometric inputs to authenticate #2686

Open
31j opened this issue Sep 16, 2023 · 5 comments
Open

[BUG] Passphrase caching requires 2-5 biometric inputs to authenticate #2686

31j opened this issue Sep 16, 2023 · 5 comments
Labels
A-PGPainless Area: PGPainless-backed PGP A-UI-UX Area: General UI/UX concerns C-bug Category: This is a bug P-medium Priority: medium
Milestone

Comments

@31j
Copy link

31j commented Sep 16, 2023

Describe the bug

When auto filling credentials on a website, password caching requires more than 1 biometric authentication. Normal passphrase mode only requires 1 input of the password for the gpg keys to decrypt the secrets.

Steps to reproduce

Steps to reproduce the behavior:

  1. Go to Settings -> PGP Settings
  2. Click on Enable Passphrase Caching
  3. Open web browser and navigate to a site requiring credentials
  4. Click on the pop-up
  5. Decryption requires 2-5 fingerprint presses / iris scans

Expected behavior

To decrypt secrets, it should only take 1 successful biometric input rather than several.

Screenshots

No response

Device information

  • Device: Samsung Galaxy Note 9
  • OS: Android Q (10)
  • App version: 2.0.0-SNAPSHOT

Additional context

  • Web Browser: Brave
  • The SSH Biometric authentication only requires 1 biometric input
@31j 31j added C-bug Category: This is a bug S-awaiting-triage Status: New issues that have not been assessed yet labels Sep 16, 2023
@31j 31j changed the title [BUG] Passphrase caching requires 2-5 biometric authentications [BUG] Passphrase caching requires 2-5 biometric inputs to authenticate Sep 16, 2023
@msfjarvis
Copy link
Member

That shouldn't be happening 🤔

I know that on multi-page forms you will get prompted for each page you fill a field on, is that what you're talking about?

The reason for the app requesting authentication each time is that while the platform considers a successful biometric auth as valid for a fixed period of time, it doesn't tell the app if it has a valid authentication window active so we can't assume that it is. That's why the app will authenticate you each time it unlocks the passphrase cache to decrypt the entry.

@31j
Copy link
Author

31j commented Sep 16, 2023

I know that on multi-page forms you will get prompted for each page you fill a field on, is that what you're talking about?

This isn't what I'm referring to, I'm referring to filling in a singular field. I've attached a video showing the issue on github where it requires two fingerprint presses

The "no match" that happened once or twice is likely because I have a papercut on my finger, but this issue still happened even when that wasn't the case so just ignore that :p

Screen_Recording_20230916-144936_Settings.mp4

@msfjarvis
Copy link
Member

I genuinely can not find a bug in this recording. I'll recount what I'm seeing here, and you can tell me what part I got wrong.

  1. You went to GitHub.com and initiated an Autofill request
  2. You failed to use your fingerprint a few times
  3. Fingerprint auth finally succeeded, and your username and password got filled in
  4. You selected the contents of the password field and cleared them
  5. Another autofill request was initiated
  6. You failed fingerprint authentication a few more times
  7. Fingerprint auth succeeded again, Password Store filled in your password again
  8. Video ends.

@31j
Copy link
Author

31j commented Sep 16, 2023

Every time the prompt comes up again is a new request after successful verification

The iris scanning one is probably a better example since it doesn't fail. Or is it meant to happen multiple times?

Screen_Recording_20230916-150046_Settings.mp4

@msfjarvis
Copy link
Member

That demonstrates it better, thanks. It's not supposed to be triggered multiple times and doesn't do so on my devices, but it might be an Iris + Fingerprint quirk that needs specialised handling.

@msfjarvis msfjarvis added P-medium Priority: medium A-UI-UX Area: General UI/UX concerns A-PGPainless Area: PGPainless-backed PGP and removed S-awaiting-triage Status: New issues that have not been assessed yet labels Sep 16, 2023
@msfjarvis msfjarvis added this to the v2.0.0 milestone Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-PGPainless Area: PGPainless-backed PGP A-UI-UX Area: General UI/UX concerns C-bug Category: This is a bug P-medium Priority: medium
Projects
Status: 📋 Being triaged
Development

No branches or pull requests

2 participants