4.1.1 - androguard sign --show --all is broken - same way as Androguard 3.* was broken in #764

[olokos]

Describe what you wanted to do

• is this error specific to a single file? NO
• if possible give a minimal working example where the error happens
  The error happens for all apk files with the default latest release.

Describe what you expected

to get signature output from androguard

Describe what actually happened

deprecated error with ApiException

System Information

• Androguard Version: 4.1.1 release & current MASTER
• Python Version: 3.11.7
• Operating System: Windows 10/11

Further Log Files and Output

androguard\cli\main.py", line 366, in androsign_main
    print("Fingerprint:", binascii.hexlify(x509_public_key.fingerprint))
                                           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "asn1crypto\keys.py", line 1299, in fingerprint
    raise APIException(
asn1crypto._errors.APIException: asn1crypto.keys.PublicKeyInfo().fingerprint has been removed, please use oscrypto.asymmetric.PublicKey().fingerprint instead

The issue existed in Androguard 3 source and still exists in latest 4.1.1 release, I've checked all commits after the release and there's no fix in the commits.

As a result, latest release of androguard has a broken sign functionality, this issue happens regardless of sample apk.

This is the exact same bug as #764 that still remains unfixed in the upstream repository.

[olokos]

First two commits are removed, as I did not like how the commit message name was shortened on github.com

The current PR for this issue is #1040 - I tested it and it works as designed, solving the fingerprint issue on newer androguard installations, since .fingerprint was removed from newer asn1crypto versions and moved into oscrypto instead.