Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question for split_model.m #40

Open
SHeon0412 opened this issue Feb 22, 2023 · 3 comments
Open

Question for split_model.m #40

SHeon0412 opened this issue Feb 22, 2023 · 3 comments

Comments

@SHeon0412
Copy link

Thank you for providing this really useful program!

I have one question about the example code you've offered (split_model.m).
According to the code of generating elasticities for lower layer (L2), it contains 2-L2_faln term in MS_VRH function, which is different with that of upper layer (L1) 1-L1_faln.

However, since L1_faln and L2_faln are both defined as volume fractions (up to my understanding) given as 0.3 in examples, I was confused why 2-L2_faln was used for lower layer instead of 1-L2_faln.

I attach below the part of the code related to my inquiry:

`%  ** generate layer elasticities:
%        This is a Voigt-Reuss-Hill average of the appropriately rotated olivine
%        tensor and its isotropic equivalent.
      [L1_C,~] = MS_VRH([L1_faln 1-L1_faln],...
         MS_rot3(Cani,0,-L1_dip,L1_aaz,'order',[3 2 1]),rh, Ciso, rh) ;

      [L2_C,~] = MS_VRH([L2_faln 2-L2_faln],...
         MS_rot3(Cani,0,-L2_dip,L2_aaz,'order',[3 2 1]),rh, Ciso, rh) ;`
@andreww
Copy link
Owner

andreww commented Feb 22, 2023

Yes - I think this should be "1-L2_faln" (and this is a bug).

@SHeon0412
Copy link
Author

Oh, thank you for your answer!

@andreww
Copy link
Owner

andreww commented Feb 22, 2023

We probably need to keep this issue open so (if we ever get around to changing the codebase) it gets fixed.

@andreww andreww reopened this Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants