Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of sha1 #64

Closed
wants to merge 2 commits into from
Closed

Remove use of sha1 #64

wants to merge 2 commits into from

Conversation

steveno
Copy link

@steveno steveno commented Jun 4, 2020

Fixes #49

@andrewchambers
Copy link
Owner

andrewchambers commented Jun 4, 2020 •
edited

Thanks, this looks great. I will merge soon.

I'm still thinking if I can do something where I can store a shorter path on disk, but a full hash in the package database.

@steveno
Copy link
Author

steveno commented Jun 6, 2020

I don't know if it's related to this change or not but I got this error trying to compile the seed:

truncated output

'/home/steveno/.hermes/hermes-store/hpkg/a0c314a64c37a0bc367137f6f4c3e833428de80c-mcm-gcc/x86_64-linux-musl/lib/libatomic.la' -> '/home/steveno/.hermes/hermes-store/hpkg/227a75927077efbeb31e886c7078d144d1d7704a-new-seed/x86_64-linux-musl/lib/libatomic.la'
'/home/steveno/.hermes/hermes-store/hpkg/a0c314a64c37a0bc367137f6f4c3e833428de80c-mcm-gcc/x86_64-linux-musl/lib/libssp_nonshared.a' -> '/home/steveno/.hermes/hermes-store/hpkg/227a75927077efbeb31e886c7078d144d1d7704a-new-seed/x86_64-linux-musl/lib/libssp_nonshared.a'
'/home/steveno/.hermes/hermes-store/hpkg/a0c314a64c37a0bc367137f6f4c3e833428de80c-mcm-gcc/x86_64-linux-musl/lib/libatomic.a' -> '/home/steveno/.hermes/hermes-store/hpkg/227a75927077efbeb31e886c7078d144d1d7704a-new-seed/x86_64-linux-musl/lib/libatomic.a'
'/home/steveno/.hermes/hermes-store/hpkg/a0c314a64c37a0bc367137f6f4c3e833428de80c-mcm-gcc/x86_64-linux-musl/lib' -> '/home/steveno/.hermes/hermes-store/hpkg/227a75927077efbeb31e886c7078d144d1d7704a-new-seed/x86_64-linux-musl/lib'
'/home/steveno/.hermes/hermes-store/hpkg/a0c314a64c37a0bc367137f6f4c3e833428de80c-mcm-gcc/x86_64-linux-musl' -> '/home/steveno/.hermes/hermes-store/hpkg/227a75927077efbeb31e886c7078d144d1d7704a-new-seed/x86_64-linux-musl'
error: File exists: ./busybox -> strings
  in os/symlink
  in <anonymous> [/home/steveno/Projects/lisp/hpkgs/seed-out.hpkg] (tailcall) on line 17, column 7
  in do-build [src/pkgstore.janet] (tailcall) on line 506, column 23
error: builder failed
  in <anonymous> [src/pkgstore.janet] on line 515, column 17
  in run-builder [src/pkgstore.janet] on line 477, column 9
  in <anonymous> [src/pkgstore.janet] on line 458, column 21
  in build-pkg [src/pkgstore.janet] on line 449, column 17
  in build-pkg [src/pkgstore.janet] on line 445, column 36
  in <anonymous> [src/pkgstore.janet] on line 629, column 13
  in <anonymous> [src/pkgstore.janet] on line 433, column 3
  in <anonymous> [src/pkgstore.janet] on line 432, column 3
  in build [src/pkgstore.janet] on line 431, column 3
  in build [src/hermes-pkgstore-main.janet] on line 171, column 3
  in <anonymous> [src/hermes-pkgstore-main.janet] on line 288, column 19
  in main [src/hermes-pkgstore-main.janet] on line 285, column 3

I'm going to blow everything away and build it with the master branch and see what happens.

@andrewchambers
Copy link
Owner

May be a bug, I didn't add CI for seed_out as I didn't want to waste too much CPU for every commit, will have a look.

@andrewchambers
Copy link
Owner

@steveno fixed in andrewchambers/hpkgs#115

@steveno steveno closed this by deleting the head repository Mar 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove sha1 dependency.
2 participants
@steveno @andrewchambers