Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical resource ID returned to custom resource ought to be the domain name #7

Open
erincerys opened this issue Dec 21, 2018 · 0 comments

Comments

@erincerys
Copy link

It'd appear that when this was written, the DomainId was thought to be the proper physical resource ID to return, and as such, the return was modeled after that. Built-in resource AWS::Elasticsearch::Domain returns its physical resource ID as the domain name. This can be referenced to e.g. construct ARNs in policies. This function returns <accountId>/<domainName> as the physical resource ID for the custom resource on creation. This causes references to the custom resource in CFN to produce unexpected results and errors. I've submitted a PR to have the custom resource's physical resource ID be consistent with what the equivalent build-in ES domain resource returns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant