Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zicsr extension is left unimplemented #33

Open
TheThirdOne opened this issue Oct 5, 2019 · 1 comment
Open

Zicsr extension is left unimplemented #33

TheThirdOne opened this issue Oct 5, 2019 · 1 comment

Comments

@TheThirdOne
Copy link

TheThirdOne commented Oct 5, 2019

I have been working on making sure the Zicsr extension is fully implemented in RARS and so I tried out Jupiter confirm my expectations from my reading of the specification.

I was very surprised when i tried to use FRCSR x5, saw that it compiled to csrrs x5, 11, x0 and when executed didn't change t0. I expected it to use csrrs x5, 3, x0.

When I looked into the code I found https://github.com/andrescv/Jupiter/blob/00041f32017a010077397640c673dbc541406962/src/main/java/jupiter/riscv/instructions/itype/CSRRC.java#L39-L42

It would be nice if there was some indication that CSR instructions were not expected to work. A warning when assembled or a note in the documentation would be enough (I guess this issue now serves that purpose).

@andrescv
Copy link
Owner

andrescv commented Oct 7, 2019

Thanks for the recommendation, I left the Zicsr extension there as a placeholder for a future implementation. I will add a warning message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants