Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modernize the project (ESM) #13

Open
ciscoheat opened this issue Mar 26, 2024 · 2 comments
Open

Modernize the project (ESM) #13

ciscoheat opened this issue Mar 26, 2024 · 2 comments

Comments

@ciscoheat
Copy link

Hi, this is a very nice library, I was just wondering if it's still active, and if you would like it to be upgraded to fully use ESM through esbuild and testing with vitest, instead of all the babel, webpack and other outdated tools for building it? I can make a PR for that.

@andreekeberg
Copy link
Owner

Hej @ciscoheat! Thanks, and yes it is, I just haven't had the time to finish up a lot of planned improvements and fixes!

This actually sounds very nice, I've been looking into different options for a new build system to replace webpack, including Rollup and Vite. For compatibility reasons I would still likely want to use include some level of transpilation and polyfilling for the dist files, and regarding migrating to ESM, which definitely streamlines things and is something I usually do nowadays for all projects, I am not 100% sure whether I want to fully do this here and thereby impose a requirement of using ESM for any project that depends on this library.

The browser support definitely doesn't have to go as far back as it currently does, but I am hesitant about only supporting evergreen browsers, so it's definitely a question of balancing modernity with compatibility.

I am working on finishing an upcoming new major version with a lot of fixes and improvements, and I'm thinking that I could definitely publish this in a development branch where you would be more than welcome to make a PR with your suggestions, and I would look it over and see how I would pull it all together for the official release of version 3.0.0!

@ciscoheat
Copy link
Author

Sounds great, I just made a PR with what I got so far. It really simplifies things moving away from babel. #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants