Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not work on 7zipped files, needs to be extracted to work. #33

Open
Elijah067 opened this issue Nov 17, 2020 · 3 comments
Open

Does not work on 7zipped files, needs to be extracted to work. #33

Elijah067 opened this issue Nov 17, 2020 · 3 comments

Comments

@Elijah067
Copy link

I tried to use this on my DS no-intro set which is 7zipped but the generator says that WARNING: no eligible candidates for <rom name> have been found!. I tried to extract the roms and the generator works fine.

I also tried --no-scan on the 7zipped rom files and it also does not work. Maybe due to the file extensions.

@andrebrait
Copy link
Owner

Indeed, it cannot check the contents of 7-zip archives. That is already implemented in DATROMTool and it does work, but it won't be implemented in 1g1r-romset-generator.

If you want to use --no-scan with compressed files, you need to add -e 7z so it knows it can match .7z files by name. Otherwise, it'll look only for .nds files (or whatever happens to be the extension used in the DAT you're using).

@jvook
Copy link

jvook commented Dec 21, 2021

ROMSorter will convert 7z and rar rom collections to standard zip so they work with 1g1r generator script
https://github.com/drakewill-CRL/ROMSorter

@andrebrait
Copy link
Owner

@jvook just a FYI, I have something in the works for that as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants