Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version of polylux2pdfpc #133

Open
diogotcorreia opened this issue Jan 12, 2024 · 4 comments
Open

Version of polylux2pdfpc #133

diogotcorreia opened this issue Jan 12, 2024 · 4 comments

Comments

@diogotcorreia
Copy link

diogotcorreia commented Jan 12, 2024

Hey!

I'm packaging polylux2pdfpc but we're not sure about what version to apply to this package.
NixOS/nixpkgs#280525

Would it be possible to do one of the following?

  • Match the version in Cargo.toml with the one from polylux itself
  • Tag it with its own tags (e.g., polylux2pdfpc-v0.1.0)
  • Some other solution you think it's preferable

Regardless of which solution you choose, I'd appreciate if you could make a new release, so that I could use that tag in the package.

Thanks a lot for the great work, just used polylux in a presentation today and it worked flawlessly!

@andreasKroepelin
Copy link
Owner

I'm not sure I understand your request. Could you try explaining it further?

Also, are you aware of the Nix packaging of polylux2pdfpc that @drupol did?

@diogotcorreia
Copy link
Author

diogotcorreia commented Jan 13, 2024

@andreasKroepelin

Hey, thanks for the reply!
The problem here is that the version in Cargo.toml is 0.1.0, while the version of the parent project is 0.3.1:

version = "0.1.0"

Therefore, it makes it seem like the versions are not in sync. I think the easiest way would be to just bump it up to the same version (i.e., 0.3.2; please make a new release, so I can use the new tag in the package), or, alternatively, just make a different tag for it and keep them unsynchronized.
Relevant discussion downstream: NixOS/nixpkgs#280525 (comment)

I was not aware of that PR adding a nix flake, no, but it is possible to have both the packaging as a flake here and as a package in nixpkgs.

Let me know your thoughts on this.

@andreasKroepelin
Copy link
Owner

Okay, got it. And I'm not really knowledgable regarding Nix, so sorry for my ignorance 😅

I will then make the version of polylux2pdfpc be synced with Polylux. Thanks for the explanation and I'm glad you enjoyed using Polylux!

@diogotcorreia
Copy link
Author

No problem! Nix really is a journey of its own :)

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants