Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDIM code doesn't work #44

Open
Dendiiiii opened this issue Aug 25, 2023 · 4 comments
Open

DDIM code doesn't work #44

Dendiiiii opened this issue Aug 25, 2023 · 4 comments

Comments

@Dendiiiii
Copy link

Dendiiiii commented Aug 25, 2023

I saw the respace.py file creates a DDIM skip time step, but when I set the <use_ddim=true>, the code in the test.py file<sample_fn = (diffusion.p_sample_loop if not conf.use_ddim else diffusion.ddim_sample_loop)> does not work because there is no definition of the method <ddim_sample_loop>.

Is the DDIM code unfinished?

How does the DDIM skip_type work with the resampling schedule?

@Dendiiiii Dendiiiii changed the title DDIM code doesn DDIM code doesn't work Aug 25, 2023
@JackPieCZ
Copy link

The code is based on guided diffusion by OpenAI where there is an option to use DDIM. The line you mentioned is probably just a fragment of the old code that was left unnoticed.

@StonyB
Copy link

StonyB commented Oct 11, 2023

How did you solve this problem?
how did you make the DDIM code work??

@JackPieCZ
Copy link

JackPieCZ commented Oct 11, 2023

@StonyB During the process of reusing the OpenAI repo for inpainting many unnecessary functions were removed (DDIM etc). If you need this functionality you would have to manually add them from the original OpenAI repository. Personally, I didn't need this functionality so I just removed DDIM parameter in config file

@StonyB
Copy link

StonyB commented Oct 12, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants