Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for vector inequality are testing sequences #15

Open
mratsim opened this issue May 21, 2017 · 2 comments
Open

Tests for vector inequality are testing sequences #15

mratsim opened this issue May 21, 2017 · 2 comments

Comments

@mratsim
Copy link

mratsim commented May 21, 2017

In line 93 to 145 in equality, it's a seq that is tested not the vectors. Is that intended?
https://github.com/unicredit/linear-algebra/blob/master/tests/equality.nim#L93

@mratsim
Copy link
Author

mratsim commented May 21, 2017

I see the same pattern in ops testing: https://github.com/unicredit/linear-algebra/blob/master/tests/ops.nim#L529

@andreaferretti
Copy link
Owner

Yup, dynamic vectors are in fact just seqs: https://github.com/unicredit/linear-algebra/blob/master/linalg/private/types.nim#L24-L25

I saw no good reason not to do this, and I thought that since seqs are so ubiquitous, this might save a few copies here and there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants