Skip to content
This repository has been archived by the owner on May 19, 2020. It is now read-only.

Can't upgrade from 0.12.6 -> 0.12.7 #1269

Open
marc0tjevp opened this issue Mar 7, 2018 · 8 comments
Open

Can't upgrade from 0.12.6 -> 0.12.7 #1269

marc0tjevp opened this issue Mar 7, 2018 · 8 comments
Assignees

Comments

@marc0tjevp
Copy link

marc0tjevp commented Mar 7, 2018

Summary

When promped with an upgrade, the download buttons does not work, clicking it returns sendAjax is not a function in the console.

Expected Behaviour

The upgrade downloads and is applied.

Actual Behaviour

  • Log in into admin environment
  • Get promped with upgrade
  • Download button does not work

Context details (if applicable)

  • Anchor version: 0.12.6
  • Server setup: Apache/2.4.29 (Unix)
@CraigChilds94
Copy link
Member

@marc0tjevp That's an odd one; mind trying it again?

@marc0tjevp
Copy link
Author

@CraigChilds94 I just tried again, still the same result.

@TheBrenny
Copy link
Member

TheBrenny commented Mar 8, 2018 via email

@CraigChilds94 CraigChilds94 added this to To do in Current Version Mar 8, 2018
@CraigChilds94 CraigChilds94 moved this from To do to In progress in Current Version Mar 8, 2018
@CraigChilds94 CraigChilds94 self-assigned this Mar 9, 2018
@joshvickerson
Copy link

I'm having this problem as well, trying to go from 0.12.3 to 0.12.7. Attached screenshot of the console error.
screen shot 2018-03-12 at 11 31 18 am

@marc0tjevp
Copy link
Author

@TheBrenny Checked the network tab, there's no request. Clicking the button just adds a # to the url.

@evansharp
Copy link
Contributor

wow, Zepto again. From what @TheBrenny just said, I'd guess the the handler for the button is malformed. From @joshvickerson's stacktrace, it looks like the event is firing and request is sending, but the response is not not what's expected.

Could be another push towards that Vanilla rewrite we talked about. All these JS bugs might shake out if we just refactored Zepto out of the picture...

@TheBrenny
Copy link
Member

@evansharp The stacktrace also looks like it's more an issue with what the server is sending back; ie, it's not actually sending a JSON response... This usually happens becuase we (probably I) may have missed a step in setting the return to be JSON instead of HTML.

@evansharp
Copy link
Contributor

@TheBrenny But of course if we replaced Zepto, bugs like that would come out in the wash ;)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Current Version
  
In progress
Development

No branches or pull requests

5 participants