Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation Request #223

Open
Insolita opened this issue Oct 25, 2017 · 3 comments
Open

Documentation Request #223

Insolita opened this issue Oct 25, 2017 · 3 comments

Comments

@Insolita
Copy link

I'll just describe here the most obscure points

  • Since 5.5 Repository was marked as deprecated, what is alternative - full custom realizations with mapper injection, or something else?
  • Accordingly (Feature Request) Ability to map entity attributes to column names #142 there is ability to map entity attributes to column names - what about similar behavior for properties?
  • Example for transactions
  • Example for incremental/decremental operations ( with queries like UPDATE table SET "foo"="foo"+1)
  • Pros and cons for embedded objects instead of classic valueObjects via getters and setters
  // ...
  public function setStatus(StatusObject $status){
       $this->status = $status->getValue();
       $this->code = $status->getCode();
  }
  public function getStatus():StatusObject{
       return new StatusObject($this->status, $this->code);
  }

Of course, embedded objects are resolved automatically, but in some cases they can bring overhead?

@RemiCollin
Copy link
Member

Noted!

Quickly Aabout repositories, I felt that they should belong to the application layer, and that the package should not be opinionated on their implementation. Also using repositories is totally up to the user, and mostly depends on application design choices, thus the deprecation

@quetzyg
Copy link
Contributor

quetzyg commented Oct 26, 2017

Totally agree with @RemiCollin. The user should be responsible for creating the repositories (if they see fit).

@Insolita
Copy link
Author

Insolita commented Oct 26, 2017

I also agree. First, each repository should have the correct phpdoc type hints for the find * methods and we were forced to override the parent methods for convenient work. Anyone can write generator with core methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants