Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if the debug or spt (singlePassType) params are used anywhere #102

Open
rcebulko opened this issue Mar 11, 2020 · 2 comments
Open
Assignees

Comments

@rcebulko
Copy link
Contributor

The service has code to handle each, but neither is used in https://github.com/ampproject/amphtml/blob/master/src/error.js and AFAICT neither shows up in any of the logs.

/cc @jridgewell Are you familiar with these by chance?

@rcebulko rcebulko self-assigned this Mar 11, 2020
@jridgewell
Copy link
Contributor

/cc @erwinmombay

@erwinmombay
Copy link
Member

Id like to leave spt for now in the code base, I'd like to use it to split the traffic for single pass and its myriads of obfuscation errors

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants