Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error: Object function Number() { [native code] } has no method 'parseFloat' #20927

Closed
sparhami opened this issue Feb 19, 2019 · 2 comments
Closed
Assignees

Comments

@sparhami
Copy link

This error is coming from: https://github.com/ampproject/animations/blob/a83edf3a9e5df55c6451e8d14c3a59bf1437dfe0/src/object-position.ts#L19

It looks like Number.parseFloat is not supported in IE, and the global parseFloat should be used instead.

@alanorozco
Copy link
Member

alanorozco commented Feb 21, 2019

There's a lint rule for this specifically.

Sorry this bit ya. If all ts is bypassing the linter then that could be worrisome for other, more critical cases.

@sparhami
Copy link
Author

There's a lint rule for this specifically.

Sorry this bit ya. If all ts is bypassing the linter then that could be worrisome for other, more critical cases.

The problem is the code is in a separate repo that does not have all the AMP linting, etc. I added linting to the list of issues here: ampproject/animations#7

We want to standardize the process / infra for creating one of these standalone repos in the future, it just isn't something we have yet 😞.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants