Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version concept was deprecated upstream #444

Open
schlessera opened this issue Dec 14, 2021 · 2 comments
Open

Latest version concept was deprecated upstream #444

schlessera opened this issue Dec 14, 2021 · 2 comments
Assignees

Comments

@schlessera
Copy link
Collaborator

The AMP project has deprecated the concept of latestVersion and -latest binaries: ampproject/amphtml#36749

Right now, we use that data for the AutoExtensions transformer to figure out which version of a component to pull in.

Instead of relying on the latestVersion, we'll have to pick the most appropriate one from the list of "available" versions. We need to figure out what that means for experimental versions, as we want to default to stable versions unless otherwise requested.

@schlessera schlessera added the P0 High Priority label Dec 14, 2021
@schlessera
Copy link
Collaborator Author

Related change in the JS toolbox (with outstanding issues): ampproject/amp-toolbox#1272

@westonruter
Copy link
Member

I've asked for there to be a new reference to easily read which component versions are still experimental: ampproject/amphtml#36749 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants