Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Approval should not clobber sizes #1449

Open
samouri opened this issue Aug 2, 2021 · 0 comments
Open

FR: Approval should not clobber sizes #1449

samouri opened this issue Aug 2, 2021 · 0 comments

Comments

@samouri
Copy link
Member

samouri commented Aug 2, 2021

summary

Normally, the bundle size check will show the delta for each file with a size change in the PR.
After approval, all the deltas are wiped away. Ideally they should be retained.

Screen Shot 2021-08-02 at 1 51 17 PM

cc @danielrozenberg

@samouri samouri changed the title Approval should not clobber sizes FR: Approval should not clobber sizes Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant