Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #664 Handle URL-encoded cookie values #686

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: #664 Handle URL-encoded cookie values #686

wants to merge 1 commit into from

Conversation

dajinchu
Copy link

@dajinchu dajinchu commented Mar 22, 2024 •
edited

Summary

Fixes #664

Cookie values are often URL-encoded. In Rails, for example, there is no way to opt out of url-encoding cookies. So this code in the docs does not work.

Checklist

  • Does your PR title have the correct title format?
  • Does your PR have a breaking change?: no

seantarzy
seantarzy approved these changes Mar 22, 2024
View reviewed changes
Copy link

@seantarzy seantarzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May rails devs not have this issue again

@jeremyallison
Copy link

@kwalker3690 any chance someone with write access could approve and merge this fix in the near future? 🙏 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremyallison jeremyallison jeremyallison approved these changes

@seantarzy seantarzy seantarzy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Browser SDK cannot handle url-encoded cookie values
3 participants
@dajinchu @jeremyallison @seantarzy