Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch memory and restart workers #22

Open
rybakit opened this issue Jul 17, 2017 · 4 comments
Open

Watch memory and restart workers #22

rybakit opened this issue Jul 17, 2017 · 4 comments

Comments

@rybakit
Copy link
Contributor

rybakit commented Jul 17, 2017

Consider to implement the "watch and restart workers" feature described in https://github.com/amphp/aerys/issues/135.

@kelunik
Copy link
Member

kelunik commented Jul 17, 2017

We should only restart workers if there's no running task IMO.

@trowski
Copy link
Member

trowski commented Oct 29, 2018

New original issue link: amphp/http-server#135.

I wanted to gauge interest in this issue. It probably would be fairly straightforward to implement, but at the moment I don't see it as much of a priority. If a worker crashes, the worker is removed from the pool automatically. However this might cause a task to fail that had nothing to do with the reason for the worker crashing, so there is definitely reason to look at a soft memory limit and restart a worker gracefully before it hits that limit.

@rybakit
Copy link
Contributor Author

rybakit commented Nov 2, 2018

@trowski I'm still interested in this feature for the reason you stated, though I can't say it's urgent or critical to me atm.

@Ekstazi
Copy link
Contributor

Ekstazi commented Dec 4, 2018

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants