Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combiner taking too much time to execute #131

Open
FahadShahid143 opened this issue Oct 23, 2023 · 1 comment
Open

Combiner taking too much time to execute #131

FahadShahid143 opened this issue Oct 23, 2023 · 1 comment

Comments

@FahadShahid143
Copy link

Combiner takes too much time to execute. Below code takes several hours to execute. Is there a way to improve it?

combiner = toad.transform.Combiner()
combiner.fit(X=x_train,
y=x_train['label'],
method='chi',
min_samples = 0.05,
exclude=exclude_list)

@Secbone
Copy link
Member

Secbone commented Dec 10, 2023

@FahadShahid143 yes, it does only merge two values in a single step when using 'chi', it will take a long time when the unique value is too much, so I think if it can merge multiple values in a single step will improve the speed.
I will work on it, and release the new version as soon as possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants