Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Release #1366

Closed
girlpunk opened this issue Feb 9, 2024 · 13 comments
Closed

Updated Release #1366

girlpunk opened this issue Feb 9, 2024 · 13 comments

Comments

@girlpunk
Copy link

girlpunk commented Feb 9, 2024

Is it possible to update the latest "released" version of proselint? I can see that quite a number of updates and bugfixes have been made since the last release, including for support of Python 3.12.0. This is causing some upstream projects that make use of proselint (such as megalinter) to fail after upgrading to Python 3.12, even though the version in git is able to support it.

@Nytelife26
Copy link
Member

Nytelife26 commented Feb 9, 2024

This will be resolved following a release after the refactor PR #1361 is merged.

However, if necessary, I should be able to make a release in the meantime.

@echoix
Copy link

echoix commented Feb 9, 2024

Great initiative and investigation! Of course if there are no releases, we can't be better then them ;)

@Nytelife26
Copy link
Member

Of course if there are no releases, we can't be better then them ;)

I am not really sure what this is trying to say, to be honest, but I'll roll with it. I acknowledge that proselint needs updated releases, and we're working on it.

I just hope the credentials will still work. I lost contact with the project owner many years ago.

@mavit
Copy link
Contributor

mavit commented Mar 18, 2024

I think there's value in an interim release for Python 3.12 compatibility, assuming the refactor could take a while.

@Nytelife26
Copy link
Member

I think there's value in an interim release for Python 3.12 compatibility, assuming the refactor could take a while.

It would appear the refactor will indeed take a while. I will ensure everything is stable, and then try a new release.

@Nytelife26
Copy link
Member

Nytelife26 commented Apr 23, 2024

We are arriving at issues I am no longer able to fix. The token for codecov seems to have expired, and I lack the administrative access to the repository required to update it. Normally, I would not consider releasing under these conditions, but nothing has changed since the most recent commit, in which all tests passed.

As such, until I can restore continuous integration to a working state, assuming the credentials for PyPI remain useable, 0.14.0 may be the final release for some time. I hope this is a workable solution for you all. I assure you I have been trying my best to contact Professor Suchow, and we received a response once, but no follow up when we tried to arrange a meeting.

Update: Bust. The previously used release system is no longer supported, and I do not have access to generate a PyPI API token. That pretty much seals the fate of the project, unless either I hear from Professor Suchow, or enough interested people remain to warrant forking the project. For now, I would recommend installing proselint as a git dependency on the tagged release. If necessary, I can upload the generated release artefacts from the CD run.

@Nytelife26 Nytelife26 added this to the 1.0.0 milestone Apr 23, 2024
@sigmavirus24
Copy link

@Nytelife26 I don't need a release but saw you close an issue I had commented on years ago and was looking at the project.

https://hynek.me/articles/ditch-codecov-python/ should help with code coverage

https://peps.python.org/pep-0541/#how-to-request-a-name-transfer has instructions for you to request that PyPI admins give you sufficient privileges to release

@Nytelife26
Copy link
Member

@Nytelife26 I don't need a release but saw you close an issue I had commented on years ago and was looking at the project.

It's always fun to know someone that contributed a lot to the tooling you use worked on the project once upon a time.

Your suggestions are much appreciated. I will at the very least make an effort to contact them :)

@sigmavirus24
Copy link

Also if appears Jordan Suchow is now a professor at my alma mater so I can reach out to the department head if need be

@Nytelife26
Copy link
Member

Also if appears Jordan Suchow is now a professor at my alma mater so I can reach out to the department head if need be

If you wouldn't mind, I would appreciate that. Maybe give it a week or so, as I sent an email to what appears to be an updated email address last night, and Professor Suchow has recent commits on his profile.

Thank you for your help, anyway.

@sigmavirus24
Copy link

Feel free to ping me when you want me to reach out. I'll definitely forget if I need to wait a week or anything

@Nytelife26
Copy link
Member

there is, in the meantime, an updated release on github, if the projects you mentioned are able to use git dependencies. this should be sufficient while i wait on a long-term solution.

@Nytelife26
Copy link
Member

@girlpunk I have news for you. As of today, I have all the requisite permissions to make things like interim releases, following a meeting with Professor Suchow.

Here you go: https://pypi.org/project/proselint/0.14.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants