Subsonic API returns an array instead of a single object with user details.

[4WaYDp]

Description

I just installed Ampache and tried to connect Play:Sub through the Subsonic API. Play:Sub would always crash after the getUser.view call.

Describe the bug

Subsonic API returns an array for user in the getUser.view call. This should not be an array because it will always return one (current) user. Play:Sub crashes on this at startup.

To reproduce

{
"subsonic-response": {
"status": "ok",
"version": "1.16.1",
"type": "ampache",
"serverVersion": "6.3.1",
"user": [
{
"username": "test",
"email": "test@test.eu",
"scrobblingEnabled": true,
"adminRole": false,
"settingsRole": true,
"downloadRole": false,
"playlistRole": true,
"coverArtRole": false,
"commentRole": false,
"podcastRole": true,
"streamRole": true,
"jukeboxRole": false,
"shareRole": true,
"videoConversionRole": false
}
]
}
}

Expected behavior

{
"subsonic-response": {
"status": "ok",
"version": "1.16.1",
"type": "ampache",
"serverVersion": "6.3.1",
"user": {
"username": "test",
"email": "test@test.eu",
"scrobblingEnabled": true,
"adminRole": false,
"settingsRole": true,
"downloadRole": false,
"playlistRole": true,
"coverArtRole": false,
"commentRole": false,
"podcastRole": true,
"streamRole": true,
"jukeboxRole": false,
"shareRole": true,
"videoConversionRole": false
}
}
}

Environment

• Ampache-docker version: 6.3.1
• Web server + version: NGINX 1.24.0
• Server operating system: Ubuntu 5.15.0-102-generic
• Client operating system: iOS 17.4.1

Client type

• SubSonic: Play:Sub v2023.2

Possible solution

I changed line 132 in src/Module/Api/Subsonic_Api.php from 'user' to 'users'. I believe that 'users' should be an ALWAYS_ARRAY. Play:Sub now connects correctly and does not crash anymore.

[lachlan-00]

You're right, i can see that in the spec. i'll fix now

[lachlan-00]

set with 73106a9 i'll be doing a 6.4 release soon with a lot of fixes in there