Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing particular podcast RSS feed breaks config file #3927

Open
george-viaud opened this issue Apr 10, 2024 · 3 comments
Open

Importing particular podcast RSS feed breaks config file #3927

george-viaud opened this issue Apr 10, 2024 · 3 comments

Comments

@george-viaud
Copy link

george-viaud commented Apr 10, 2024

Description

When importing a particular RSS feed file from a popular podcaster, the config is somehow damaged and needs to be re-written

To reproduce

  1. Go to Podcasts and add the following podcast:
  2. https://feeds.redcircle.com/9507222a-a73f-4e9a-993a-3d79d59e6131
  3. You will land on index.php# with a blank page
  4. The system now says Your Ampache config file is out of date!
  5. Podcast is not subscribed and the system is now borked until config re-written

Expected behavior

Podcast is subscribed without error and without damaged config
or
Descriptive error is given as to why the feed is invalid and the config is not somehow damaging the config

Environment

  • Ampache version: 6.3.1 via ampache-docker
  • Server operating system: Ubuntu 22.04

Client type

  • Web
@lachlan-00
Copy link
Member

the error in this feed is the generator length, at least on the demo site which is 6.3.1 right now.

<generator>
RedCircle VERIFY_TOKEN_9507222a-a73f-4e9a-993a-3d79d59e6131 -- Rendered At Wed, 10 Apr 2024 02:39:11 +0000
</generator>

causes the insert to fail

Error_query SQL: INSERT INTO `podcast` (`catalog`, `feed`, `title`, `website`, `description`, `language`, `generator`, `copyright`, `total_skip`, `total_count`, `episodes`, `lastbuilddate`, `lastsync`) VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?) [2,"https:\/\/feeds.redcircle.com\/9507222a-a73f-4e9a-993a-3d79d59e6131","The Peter Schiff Show Podcast","https:\/\/redcircle.com\/shows\/the-peter-schiff-show-podcast6622","<p>Peter Schiff is an economist, financial broker\/dealer, author, frequent guest on national news, and host of the Peter Schiff Show Podcast. The podcast focuses on economic data analysis and unbiased coverage of financial news, both in the U.S. and global markets. As entertaining as he is informative, Peter packs decades of brilliant insight into every news item. Join the thousands of fans who have benefited from Peter\u2019s commitment to getting the real story out to the world.<\/p>","en-US","RedCircle VERIFY_TOKEN_9507222a-a73f-4e9a-993a-3d79d59e6131  -- Rendered At Wed, 10 Apr 2024 02:45:11 +0000","2023",0,0,0,0,0]
2024-04-10T02:48:55+00:00 [user] (Ampache\Module\System\Dba) -> Error_query MSG: SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'generator' at row 1

you're getting config out of date cause it's failing to completely load the pages when it fails

@lachlan-00
Copy link
Member

updated the database column to allow larger generator fields and i can add it in develop with a818a61

@usox
Copy link
Contributor

usox commented Apr 10, 2024

Mental note for me: Don't forget to truncate strings in certain podcast setter methods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants