Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Democratic playlist page doesn't refresh when deleting songs #3889

Open
stebe opened this issue Mar 20, 2024 · 8 comments
Open

Democratic playlist page doesn't refresh when deleting songs #3889

stebe opened this issue Mar 20, 2024 · 8 comments

Comments

@stebe
Copy link
Contributor

stebe commented Mar 20, 2024

Description

Describe the bug

I am seeing the same issue as #3651 when updating the democratic playlist. When I delete an item from the playlist the page doesn't refresh. I'm currently on fb1009b.

To reproduce

Steps to reproduce the behavior:

  1. Go to Democratic playlist page after adding some songs
  2. Click on 'delete icon image or image
  3. Page does not automatically update although the update does show if page is manually refreshed

Environment

Client type

  • Web
@lachlan-00
Copy link
Member

good catch i was about to say we did that before. must be missing the browse id as well

@lachlan-00
Copy link
Member

try f66b7de, added the browse id and renamed the ajax to match the action

@stebe
Copy link
Contributor Author

stebe commented Mar 22, 2024

Unfortunately didn't make any difference for me. Vote does get removed but page still doesn't update.

@lachlan-00
Copy link
Member

hmm, it could be missing the extra ajax, i'll have to dig a bit more

@lachlan-00
Copy link
Member

fixed with f55f9ab it wasn't sending a browse so it would make a new one and not update the current list

@lachlan-00
Copy link
Member

the cear playlist link will also clear all the votes now with 40d30f3

@stebe
Copy link
Contributor Author

stebe commented Mar 27, 2024

Sorry took a while to test. Removing a vote does now work, but as admin deleting a song does not update and when I clear playlist all the X's become checkmarks and the vote count is zeroed. Manually refreshing the page shows that the list was actually cleared.

Screenshot_20240327_065858

@lachlan-00
Copy link
Member

that's because of how the votes are checked and removed. the objects are technically still in the browse so they don't get removed right away.

They're removed from the user_vote table and not the tmp_playlist.

the process isn't very clear though so it needs a bit more work to fully clear

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants