Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catalog Filter Editor always edits the default filter, not the selected one #3762

Open
troycarpenter opened this issue Jan 11, 2024 · 4 comments

Comments

@troycarpenter
Copy link
Contributor

Description

Describe the bug

When I select an existing catalog filter to edit, the edit screen shows that the DEFAULT catalog filter is being edited...no matter which filter I pick to edit.

To reproduce

Admin -> Show Catalog Filters

Edit any catalog filter that is not DEFAULT.
In the Edit screen, notice the filter name is DEFAULT and not the selected filter.

Expected behavior

I expect the selected filter to be edited, not the default one.

Screenshots

Environment

  • Ampache version: 6.2.1 DOCKER

Client type

  • Web
@lachlan-00
Copy link
Member

you're right, getParsedBody isn't getting the query parameters

Set 6bd8d2a81to get the $_REQUEST variables.

also added a fix to garbage collect old catalogs from the group mappings

@troycarpenter
Copy link
Contributor Author

troycarpenter commented Jan 11, 2024

Testing the fix in isolation. It does allow me to edit the correct filter, but I think the filter name is supposed to be filled with the current filter name, allowing the user to change it if necessary. With the name not auto-filled, the change isn't accepted until the user fills that in.

Should I write a new ticket for that?

@lachlan-00
Copy link
Member

that's not getting the name at all either. another thing to ID

@lachlan-00
Copy link
Member

8358df7 add the changed parameter name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants