Is there a way to name discs within an album release? #3623

troycarpenter · 2023-10-17T01:02:02Z

troycarpenter
Oct 17, 2023

Is there any way to name a disc in a multi-disc album? Sometimes boxed sets, the discs have "themes" or for some "complete studio album" releases, the discs are actual album names.

Ideally I would like to be able to edit the song via the GUI, but I would also like to have it read from file tags if possible.

Answered by lachlan-00

Oct 17, 2023

sure is #3599

discsubtitle / set subtitle tags are read and stored as a per-disk version

View full answer

lachlan-00 · 2023-10-17T02:21:38Z

lachlan-00
Oct 17, 2023
Maintainer

sure is #3599

discsubtitle / set subtitle tags are read and stored as a per-disk version

0 replies

lachlan-00 · 2023-10-17T02:22:48Z

lachlan-00
Oct 17, 2023
Maintainer

0 replies

troycarpenter · 2023-10-17T05:20:56Z

troycarpenter
Oct 17, 2023
Author

Is there a specific release this is in? I added the tag "discsubtitle" to the tracks and did an "update from tags" but it didn't change the Disk Subtitle field. Is the update from tags sufficient, or do I need to remove the album, clean the catalog, then run the add command?

I'm using 6.0.3 docker image.

6 replies

troycarpenter Oct 17, 2023
Author

I'm looking through the code. I've verified my database table album_disk has the disksubtitle field and that all entries are NULL. I also see all the proper code on my system. I have not finished looking through all of it, though. Let me do a test where I remove the properly tagged albums and let the system discover again to see if that's different than an update from tags.

troycarpenter Oct 17, 2023
Author

No. When I removed the album, did a "clean", then put it back and did an "add", I still don't see the disc subtitle.

Perhaps it's related to the tag. I have this from mediainfo:

Complete name                            : 01 - Andante in C, WoO 211 [Biamonti 52] (c. 1790-92).mp3
Format                                   : MPEG Audio
File size                                : 1.59 MiB
Duration                                 : 1 min 5 s
Overall bit rate mode                    : Constant
Overall bit rate                         : 192 kb/s
Album                                    : The New Complete Edition
Album/Performer                          : Ludwig van Beethoven
Part/Position                            : 8
Track name                               : Andante in C, WoO 211 [Biamonti 52] (c. 1790-92)
Track name/Position                      : 01
Performer                                : Ludwig van Beethoven
Genre                                    : Classical
Recorded date                            : 2019
Writing library                          : LAME3.100
Cover                                    : Yes
Cover type                               : Cover (front)
Cover MIME                               : image/jpeg
Comment                                  : From the library of The Carpenters
DISCSUBTITLE                             : Rarities
MusicBrainz Artist Id                    : 1f9df192-a621-4f54-8850-2c5373b7eac9
MusicBrainz Album Artist Id              : 1f9df192-a621-4f54-8850-2c5373b7eac9
MusicBrainz Album Type                   : album

The DISCSUBTITLE tag was added by mp3tag on WIndows and is all uppercase. From another track, I also have added the tag DISKSUBTITLE to the file, but it made no difference.

troycarpenter Oct 17, 2023
Author

So some more research tells me that the actual tag is TSST, which apparently is in id3v2.4. My tags are id3.2.3. Let me play around with that to see if I can make it work.

troycarpenter Oct 17, 2023
Author

So using Picard, I found Disc Subtitle. What showed up in mp3tag is "SETSUBTITLE". But even with that I did an "update from tags" and still didn't get anything.

My version of id3v2 on Linux doesn't support v2.4 (really?) so it now shows as "no ID3 tag". Mediainfo shows:

Complete name                            : 001 - Symphony no. 1 in C major, op. 21 I. Adagio molto - Allegro con brio.mp3
Format                                   : MPEG Audio
File size                                : 11.1 MiB
Duration                                 : 8 min 0 s
Overall bit rate mode                    : Constant
Overall bit rate                         : 192 kb/s
Album                                    : The New Complete Edition
Album/Performer                          : Ludwig van Beethoven
Part/Position                            : 1
Track name                               : Symphony no. 1 in C major, op. 21: I. Adagio molto - Allegro con brio
Track name/Position                      : 001
Performer                                : Ludwig van Beethoven
Genre                                    : Classical
Recorded date                            : 2019
Writing library                          : LAME3.100
Cover                                    : Yes
Cover type                               : Cover (front)
Cover MIME                               : image/jpeg
Comment                                  : From the library of The Carpenters
Set subtitle                             : Orchestral Music
DISCSUBTITLE                             : Orchestral Music
MusicBrainz Artist Id                    : 1f9df192-a621-4f54-8850-2c5373b7eac9
MusicBrainz Album Artist Id              : 1f9df192-a621-4f54-8850-2c5373b7eac9
MusicBrainz Album Type                   : album

The Set Subtitle tag is there now, but no change.

lachlan-00 Oct 19, 2023
Maintainer

i see in generic cleanup it's around the wrong way b9e835f

troycarpenter · 2023-10-17T20:59:10Z

troycarpenter
Oct 17, 2023
Author

Uncommented debug_event on line 2571 in src/Repository/Model/Catalog.php I then updated a song from tags, but in the debug output I see that disksubtitle in the result array is empty. Swimming upstream.

Adding a similar debug_event after get_media_tags in line 2540, I see that array element is still blank. Need to go into get_media_tags now.

In get_media_tags, I put another debug_event statement (disastrously because I think it tried to print the binary representation of the album art). However, before that happened, I saw:

2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->             [tags] => Array
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                 (
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                     [id3v2] => Array
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                         (
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                             [album] => Array
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 (
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                     [0] => The New Complete Edition
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 )
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) -> 
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                             [artist] => Array
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 (
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                     [0] => Ludwig van Beethoven
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 )
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) -> 
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                             [band] => Array
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 (
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                     [0] => Ludwig van Beethoven
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 )
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) -> 
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                             [comment] => Array
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 (
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                     [0] => From the library of The Carpenters
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 )
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) -> 
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                             [part_of_a_set] => Array
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 (
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                     [0] => 1
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 )
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) -> 
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                             [genre] => Array
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 (
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                     [0] => Classical
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 )
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) -> 
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                             [title] => Array
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 (
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                     [0] => Symphony no. 1 in C major, op. 21: I. Adagio molto - Allegro con brio
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 )
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) -> 
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                             [track_number] => Array
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 (
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                     [0] => 001
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 )
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) -> 
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                             [year] => Array
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 (
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                     [0] => 2019
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 )
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) -> 
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                             [text] => Array
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 (
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                     [DISCSUBTITLE] => Orchestral Music
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                     [MusicBrainz Album Artist Id] => 1f9df192-a621-4f54-8850-2c5373b7eac9
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                     [MusicBrainz Album Type] => album
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                     [MusicBrainz Artist Id] => 1f9df192-a621-4f54-8850-2c5373b7eac9
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                     [SETSUBTITLE] => Orchestral Music
2023-10-17T20:05:13+00:00 [troy@carpenter.cx] (Ampache\Repository\Model\Catalog) ->                                 )

So the tags are there at that level. What I can't figure out is why the value isn't being moved to it's proper place.

Looking now in the gather_tags() method.

Ok. in src/Module/Util/VaInfo.php around line 1493, I had to add:

                    case 'discsubtitle':
                        $parsed['disksubtitle'] = $id3v2['comments']['text'][$txxx['description']];
                        break;
                    case 'disksubtitle':
                        $parsed['disksubtitle'] = $id3v2['comments']['text'][$txxx['description']];
                        break;

I added both discsubtitle and disksubtitle for the reasons stated in the pull request. Just to be clear, this is in private function _cleanup_id3v2().

I have updated two multi-disk albums with these changes and they both picked up the change when the files had the "disksubtitle" tag.

1 reply

lachlan-00 Oct 19, 2023
Maintainer

set that with 02e9e3f so it will read the text frames

lachlan-00 · 2023-10-20T04:18:57Z

lachlan-00
Oct 20, 2023
Maintainer

1f2183e has more fixes, moving the queries into the check function so more can be done

0 replies

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Is there a way to name discs within an album release? #3623

{{title}}

Replies: 5 comments 7 replies

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{title}}

{{editor}}'s edit

{{editor}}'s edit

{{title}}

{{title}}

Select a reply

Is there a way to name discs within an album release? #3623

troycarpenter Oct 17, 2023

Replies: 5 comments · 7 replies

lachlan-00 Oct 17, 2023 Maintainer

lachlan-00 Oct 17, 2023 Maintainer

troycarpenter Oct 17, 2023 Author

troycarpenter Oct 17, 2023 Author

troycarpenter Oct 17, 2023 Author

troycarpenter Oct 17, 2023 Author

troycarpenter Oct 17, 2023 Author

lachlan-00 Oct 19, 2023 Maintainer

troycarpenter Oct 17, 2023 Author

lachlan-00 Oct 19, 2023 Maintainer

lachlan-00 Oct 20, 2023 Maintainer

troycarpenter
Oct 17, 2023

Replies: 5 comments 7 replies

lachlan-00
Oct 17, 2023
Maintainer

lachlan-00
Oct 17, 2023
Maintainer

troycarpenter
Oct 17, 2023
Author

troycarpenter Oct 17, 2023
Author

troycarpenter Oct 17, 2023
Author

troycarpenter Oct 17, 2023
Author

troycarpenter Oct 17, 2023
Author

lachlan-00 Oct 19, 2023
Maintainer

troycarpenter
Oct 17, 2023
Author

lachlan-00 Oct 19, 2023
Maintainer

lachlan-00
Oct 20, 2023
Maintainer