Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Separate Interfaces from Classes #324

Open
amihaiemil opened this issue Mar 3, 2020 · 2 comments
Open

Separate Interfaces from Classes #324

amihaiemil opened this issue Mar 3, 2020 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed role/DEV

Comments

@amihaiemil
Copy link
Owner

All the classes should be in their own package, for Access Control reasons. However, we can separate the interfaces from the classes. Let's try to do this without breaking backwards compatibility.

We can leave the interfaces in the current package and create an impl package for the classes.
@amihaiemil amihaiemil added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed role/DEV labels Mar 3, 2020
@irinil
Copy link

irinil commented Mar 20, 2020

Should be this mentioned in the JavaDocs too?

@amihaiemil
Copy link
Owner Author

@irinil If you want to continue contributing, I would start with other tickets, until you learn the library's architecture. For instance, the ticket about continuing with the Swarm API.

See how other API endpoints are implemented :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed role/DEV
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@amihaiemil @irinil