Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change email validation to match maxipago validation #100

Open
carvmarc opened this issue Feb 28, 2018 · 2 comments
Open

Change email validation to match maxipago validation #100

carvmarc opened this issue Feb 28, 2018 · 2 comments
Labels
Milestone

Comments

@carvmarc
Copy link
Contributor

If try a email like bar+foo@test.com, the donation system will accept, but the gateway will reject the payment. So we need to change the validation of email field on the donation form to not accept the + on the email.

@carvmarc carvmarc added the bug label Feb 28, 2018
@fernandosjp fernandosjp added this to the v0.2 milestone Feb 28, 2018
@henriquekano
Copy link
Contributor

@carvmarc AFAIK, +, along with other special characters, are valid for the email's local part. Therefore, it's totally possible for a donor to have a bar+foo@gmail.com email address being refused to donate, which sucks...

Of course we can't ignore said error, so I propose first contacting the payment gateway to hear what they have to say and, second, having a flow for these cases to contact the donor explaining the context (by email or any other method) so he can try donating using another email.

What do you think?

@carvmarc
Copy link
Contributor Author

carvmarc commented May 8, 2018

Sure makes sense contact the gateway, however now that I thought about, as this system will be used for others in the future maybe a better aproach is make the email validation confiigurable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants