Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve query parameters when moving to next step #36

Open
puopg opened this issue Nov 29, 2018 · 6 comments
Open

Preserve query parameters when moving to next step #36

puopg opened this issue Nov 29, 2018 · 6 comments
Milestone

Comments

@puopg
Copy link

puopg commented Nov 29, 2018

When the Wizard is route controlled, when I move to the next step, the url and state changes.

Now this is all good, but the query parameters are lost during that transition. So for example, I wanted to move from add -> confirm, and my route has:

/basePath/add?itemId="thisisanid"

when I move to the next step my url becomes

/basePath/confirm", when I want the url to preserve the query param as
/basePath/confirm?itemId="thisisanid"

Is there a way to do this?

@sumanalapati
Copy link

Are you not maintaining it in the state using redux or something?

@puopg
Copy link
Author

puopg commented Apr 1, 2019

Well no I can do that, just since the interface for defining steps is strictly by name, an option to preserve query params when route controlled would be nice. Otherwise, routing is the form of navigation to move to steps within the wizard, and the next() method is cooler

@skoshy
Copy link

skoshy commented Aug 26, 2019

I just added a PR that tackles this issue, #43 .

@asutedja asutedja added this to the v3 milestone Dec 11, 2019
@github-actions
Copy link

github-actions bot commented Apr 7, 2020

This issue is stale because it has been open 30 days with no activity. Remove no-issue-activity label or comment or this will be closed in 5 days.

@github-actions
Copy link

github-actions bot commented May 9, 2020

This issue is stale because it has been open 30 days with no activity.

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

This issue is stale because it has been open 30 days with no activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants