Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onNext)!: stop calling onNext in componentDidMount #90

Closed

Conversation

ryhinchey
Copy link
Contributor

@ryhinchey ryhinchey commented Mar 4, 2021

BREAKING_CHANGE: onNext will no longer be called within Wizard's componentDidMount

closes #33

Description

onNext is called within componentDidMount inside Wizard. This is confusing because no action has been taken at this point and next has not been called yet.

Motivation and Context

onNext being called inside componentDidMount is confusing for developers #33. Additionally, on initial render, you don't have the steps date or current step id to make a decision about where you might want to go.

How Has This Been Tested?

a unit test was updated to ensure onNext isn't called on render

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • My changes are in sync with the code style of this project.
  • There aren't any other open Pull Requests for the same issue/update.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • This change adds additional environment variable requirements for react-albus users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using react-albus?

if they previously depended on onNext being called on initial render, it won't get called any more.

BREAKING_CHANGE: onNext will no longer be called within Wizard's componentDidMount
@ryhinchey ryhinchey requested a review from a team as a code owner March 4, 2021 04:31
Base automatically changed from master to main March 4, 2021 17:04
@ryhinchey
Copy link
Contributor Author

closing this in favor of the functionality currently on the 3.x branch

@ryhinchey ryhinchey closed this Mar 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

onNext is called on initialization
2 participants