Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line-spacing issue causes issues with certain scripts #467

Open
suhasm opened this issue Feb 27, 2023 · 3 comments
Open

line-spacing issue causes issues with certain scripts #467

suhasm opened this issue Feb 27, 2023 · 3 comments

Comments

@suhasm
Copy link

suhasm commented Feb 27, 2023

A proofreader working with kannada has pointed out an issue where the bottommost part of certain aksharas get clipped. This causes some letters to appear like others. For instance vaṃśodbhava to appear like vaṃśodbava in the Kannada script. Can we increase the line spacing a bit? (Screenshot sent by proofreader attached)
vamshod

@kvchitrapu
Copy link
Collaborator

kvchitrapu commented Mar 1, 2023

@akprasad / @shreevatsa , can this diff address this issue? This probably is a quick hack.

diff --git a/ambuda/templates/proofing/pages/editor-components.html b/ambuda/templates/proofing/pages/editor-components.html
index 8057096..ff6cdb4 100644
--- a/ambuda/templates/proofing/pages/editor-components.html
+++ b/ambuda/templates/proofing/pages/editor-components.html
@@ -239,7 +239,7 @@ Pass `class` explicitly so that Tailwind can regex-find it when it compiles. #}
   </div>
   <textarea id="content" name="content" required=""
     class="grow p-2 md:p-4 w-full resize-none"
-    :style="`font-size: ${textZoom}rem`"
+    :style="`font-size: ${textZoom}rem;line-height: 1.5`"
     @keydown="hasUnsavedChanges = true" spellcheck="false">{{ data }}</textarea>
 </div>

@shreevatsa
Copy link
Contributor

Thanks for looking into this! I think you've found the right place, except for a couple of minor points:

  1. I think the current line-height is already 1.5 and should be increased a bit,
  2. I think the current convention is to prefer using Tailwind classes for these style things, which means that instead of directely setting line-height: 1.5 in the :style, we can try adding to the class="…" list something like leading-relaxed or leading-loose or leading-9 or leading-10 (whichever one looks good).

@akprasad
Copy link
Contributor

akprasad commented Mar 1, 2023

I've merged #462, so please rebase to ensure a clean diff. I also agree with @shreevatsa 's comments -- when those are resolved, I'll merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

4 participants