Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regex for domain detection #680

Closed
gperdomor opened this issue Nov 30, 2023 · 2 comments
Closed

Regex for domain detection #680

gperdomor opened this issue Nov 30, 2023 · 2 comments
Labels
enhancement New feature or request unconfirmed Needs triage.

Comments

@gperdomor
Copy link

Is your feature request related to a problem? Please describe.

I'm building an app which can be deployed in different environments like prod, staging and beta...

for now I solved my problem using env variables to setup de domain config inside the middleware, but I think is a good idea to allow regex for domain detection because can work for multi tenancy apps...

Describe the solution you'd like

allow domain: "*.domain.com" in middleware config and use regex to match, this approach can work with dynamic domains.

also domain: ["*.domain.com", admin.domain.com] would be a good option

Describe alternatives you've considered

N/A

@gperdomor gperdomor added enhancement New feature or request unconfirmed Needs triage. labels Nov 30, 2023
@amannn
Copy link
Owner

amannn commented Dec 1, 2023

I solved my problem using env variables to setup de domain config inside the middleware

That's what I'd recommend too.

Supporting wildcards is currently not planned. We might accept domains for the navigation APIs in the future too and wildcards wouldn't work there. Please see #444 (comment).

@amannn
Copy link
Owner

amannn commented Feb 6, 2024

Closing, since this has been addressed.

@amannn amannn closed this as completed Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request unconfirmed Needs triage.
Projects
None yet
Development

No branches or pull requests

2 participants