Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read() checks if line length < 0 ? #9

Open
Dieterbe opened this issue Jun 16, 2021 · 0 comments
Open

Read() checks if line length < 0 ? #9

Dieterbe opened this issue Jun 16, 2021 · 0 comments

Comments

@Dieterbe
Copy link

if (len(line) < 0) {

should probably check if len(line) == 0 ?

i've tried to fix it but unfortunately that breaks the tests.
haven't been able to figure out yet how the tests work, the test against the pretermined checksum is a bit strange.
i would suggest to use something like https://github.com/sergi/go-diff to show what's the diff between expected and resulting file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant