Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Add Passthrough Mode #269

Open
Schmetzler opened this issue Dec 19, 2023 · 13 comments
Open

[Feature] Add Passthrough Mode #269

Schmetzler opened this issue Dec 19, 2023 · 13 comments
Labels
feature New feature

Comments

@Schmetzler
Copy link

Are there any plans on supporting pass through?
As the camera is available this should be possible... I implemented a passthrough within google cardboard sdk
and would like to contribute to the repo. But I do not know if something is already present?

Besides I would need a little research to trigger passthrough mode via accelerator sensors (like it is triggered in the quest).

If there is some interest in this I would dig into it.

@Schmetzler Schmetzler changed the title Add Passthrough Mode [Feature] Add Passthrough Mode Dec 19, 2023
@ShootingKing-AM
Copy link
Member

ShootingKing-AM commented Dec 20, 2023

I hope you are saying that you would like to display Camera Input in ALVR lobby or something similar.
If thats so, there are no plans for this.

PRs are welcome though. I had this thoughts in my mind but it didnt even make to planning stage. This would be a good feature though :)

@ShootingKing-AM ShootingKing-AM added the feature New feature label Dec 20, 2023
@Lamonz88
Copy link

Yes. It would be amazing to have this feature because our phones have much better cameras

@Lamonz88
Copy link

I hope you are saying that you would like to display Camera Input in ALVR lobby or something similar. If thats so, there are no plans for this.

PRs are welcome though. I had this thoughts in my mind but it didnt even make to planning stage. This would be a good feature though :)

Is it actually possible to implement this feature in future updates.

I'd rather have my phone than buy another VR headst because my phone's camera is much better ..

@ShootingKing-AM
Copy link
Member

Yup it's possible, wip. Need more time or need more coffee so that I can lure in more developers to work on this :3

@Schmetzler
Copy link
Author

I already experimented with it... And had success.... But I am currently trying to build this repo, so that I can insert this code and test it... But as I am not really fond of Android development and stuck in dependency hell... It may take a while. If I have some spare time and can get around those dependency issues I would gladly contribute.

@ShootingKing-AM
Copy link
Member

What issues are you facing, you can text on #dev channel in discord for some instant help.

@Lamonz88
Copy link

I already experimented with it... And had success.... But I am currently trying to build this repo, so that I can insert this code and test it... But as I am not really fond of Android development and stuck in dependency hell... It may take a while. If I have some spare time and can get around those dependency issues I would gladly contribute.

Are looking fur funding or sponsors..?

If so , maybe you can set up donations or give is option to sponsor you on your repo.!

@Lamonz88
Copy link

Lamonz88 commented Feb 18, 2024

Yup it's possible, wip. Need more time or need more coffee so that I can lure in more developers to work on this :3

Thank you soo much for your reply..

That would we great if it's possible..

@ShootingKing-AM
Copy link
Member

I already experimented with it... And had success.... But I am currently trying to build this repo, so that I can insert this code and test it... But as I am not really fond of Android development and stuck in dependency hell... It may take a while. If I have some spare time and can get around those dependency issues I would gladly contribute.

Are looking fur funding or sponsors..?

If so , maybe you can set up donations or give is option to sponsor you on your repo.!

Yes am looking for funding and sponsors, since the work is rising and no new developers are joining.

It's already done? Or do you mean GitHub sponsors ? Is there any benefit of GitHub sponsors over open collective?

@Lamonz88
Copy link

Lamonz88 commented Feb 18, 2024

It's already done? Or do you mean GitHub sponsors ? Is there any benefit of GitHub sponsors over open collective

Sorry . I think I just mixed up you and Schmetzler..

I can see you have the open collective sponsorship.
I will donate some money .

@Schmetzler
Copy link
Author

So there is a passthrough mode available on my fork: Schmetzler/PhoneVR@a215d89.
Currently it is just available via the dropdown menu on the upper right... which is not really usable.
Next I will try to implement a gesture such as tapping the side of the headset to toggle the passthrough mode.

@ShootingKing-AM
Copy link
Member

You can make a PR to this repo. Even basic pass through is very helpful

@Schmetzler
Copy link
Author

So added the PR #313, now also with the experimental double tap detection... Well this was harder than anticipated, but it works somehow. If anyone has another suggestion how the pass-through could be detected, please let me (or us ) know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature
Projects
None yet
Development

No branches or pull requests

3 participants