Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating puppeteer to support newer Chrome features #188

Open
emersonthis opened this issue Oct 27, 2022 · 4 comments
Open

Updating puppeteer to support newer Chrome features #188

emersonthis opened this issue Oct 27, 2022 · 4 comments

Comments

@emersonthis
Copy link

Recently I tried to render a page that uses the newish CSS aspect-ratio and the resulting screenshot doesn't recognize it. I suspect the reason is that this project is pinned to puppeteer v2 which predates Chrome support for aspect-ratio.

Puppeteer is currently on v19 and it looks like Chrome added support for aspect-ratio around the time Puppeteer v13 was released. I tried updating package.json to newer versions but the API in those newer versions has changed (in ways I have not studied closely yet) so the app errors out.

@samuliasmala
Copy link

@kimmobrunfeldt if I create a PR to update the Puppeteer would you consider merging it?

@emersonthis
Copy link
Author

@samuliasmala If for some reason the maintainers don't want to support newer Puppeteer my company would be open to maintaining a fork.

@PrimeDominus
Copy link

@samuliasmala If for some reason the maintainers don't want to support newer Puppeteer my company would be open to maintaining a fork.

If you do create a maintained fork please let us know 😄

@emersonthis
Copy link
Author

@samuliasmala @PrimeDominus We just forked the repo: https://github.com/userevidence/url-to-pdf-api

if I create a PR to update the Puppeteer would you consider merging it?

We don't have the bandwidth to tackle this ourselves at the moment, but if anyone has time we'd certainly merge a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants