Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove empty "attachment" metadata entry in pre-commit notebook cleanup #4222

Open
christopherbunn opened this issue Jul 3, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@christopherbunn
Copy link
Contributor

When opening a Jupyter notebook in VSCode, occasionally it will add an empty "attachment" field in the metadata section as seen here. It is fairly easy to miss out and accidently commit this as part of a review. We should update our Jupyter notebook check to remove this field (if empty, otherwise leave it in if it has data) prior to committing. This code should run in docs/notebook_version_standardizer.py.

@christopherbunn christopherbunn added the documentation Improvements or additions to documentation label Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant