Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate better way to make integer grid values for partial dependence #4100

Open
tamargrey opened this issue Mar 21, 2023 · 0 comments
Open

Comments

@tamargrey
Copy link
Contributor

With #4095, we made the handling of integer grid values for partial dependence explicit, rounding the fractional values produced in _grid_from_X to allow IntegerNullable types to be used for partial dependence.

One downside of this method for determining grid values is that it's possible for us to end up with duplicate grid values if, say, two grid values were calculated to be 4.1 and 4.4 and then both got rounded down to 4. We should investigate if there is a better way to get integer grid values for partial dependence calculations or if there is a way for us to maintain the fractional grid values and pass those into our pipelines (this is currently not possible because of our _schema_is_equal check when transforming on new data).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant