Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PipelineBase Errors Without Estimator #229

Closed
jeremyliweishih opened this issue Nov 19, 2019 · 2 comments · Fixed by #277
Closed

PipelineBase Errors Without Estimator #229

jeremyliweishih opened this issue Nov 19, 2019 · 2 comments · Fixed by #277
Assignees
Labels
bug Issues tracking problems with existing features.

Comments

@jeremyliweishih
Copy link
Contributor

Currently we only check that if there is an estimator it is the last component.
However, the pipeline breaks on fit on the following line without an estimator:

self.input_feature_names.update({self.estimator.name: list(pd.DataFrame(X_t))})

We should either enforce that all pipelines must have an estimator or fix _fit to allow this case.

@jeremyliweishih jeremyliweishih added the bug Issues tracking problems with existing features. label Nov 19, 2019
@angela97lin angela97lin self-assigned this Nov 20, 2019
@dsherry
Copy link
Contributor

dsherry commented Dec 11, 2019

I filed #273 to track discussing the long-term plan around this (i.e., do we want to support pipelines with more than one estimator? etc.).

My suggestion: we continue discussion there, but in the meantime, we resolve this ticket by having PipelineBase::__init__ error out if an estimator is not specified as the final component. Does that seem reasonable?

Tagging @angela97lin @jeremyliweishih because we were just discussing this in slack :)

@kmax12
Copy link
Contributor

kmax12 commented Dec 11, 2019

that seems like a reasonable solution for now until we have the long term plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues tracking problems with existing features.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants