New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discuss] Is AutoClassifer.fit() and AutoRegressor.fit() the best API? #175
Comments
The way I see it, there are three decisions to make
For 1 and 2 here are the options that I came up with import evalml
clf = evalml.AutoClassifierSearch()
auto = evalml.AutoClassifierSearch()
automl = evalml.AutoClassifierSearch()
seacher = evalml.AutoClassifierSearch()
clf = evalml.AutoClassifier()
auto = evalml.AutoClassifier()
automl = evalml.AutoClassifier()
seacher = evalml.AutoClassifier() For 2 and 3 here are the options I came up with clf.search()
auto.search()
automl.search()
seacher.search()
clf.run()
auto.run()
automl.run()
seacher.run() I think I like import evalml
automl = evalml.AutoClassifierSearch()
automl.search() My reasoning is
The alternative I like is import evalml
search = evalml.AutoClassifierSearch()
search.run() This uses a more descriptive variable name, so using Any thoughts? Any variable naming approaches I missed? Even you don't think they are better, might as well throw them out there for us to consider. |
I like |
I quite like For the recommended name of the variable that holds the initialized class, I'm a fan of |
@jeremyliweishih im not sure I understand your point about |
Hopefully I'm not misunderstanding but I think @jeremyliweishih is saying |
@kmax12 I meant that comment about the recommended name of the variable: |
@jeremyliweishih i understand what you were saying now. i agree. Based on the above, I think we all like renaming to In terms of the variable name we're down too
I personally like automl since it is descriptive.
So I see two options based on the above convo
or
|
Think either would work but I i like |
I like all the ideas you've thrown out. I'm a particular fan of:
Not to complicate an already lengthy discussion with more options, but: should we say |
Yep, I agree. Regressor can also refer to the input features, variables, etc, so regression is better. In addition, if AutoClassification and AutoRegression are more analogous to "auto machine learning", since machine learning, classification, and regression are all processes. unless there's any final opposition, we'll go with
|
After you call fit, you need to select the model you want to use before calling
predict
. In that way, it's not like other objects that have a fit method.fit
is more likesearch
in this case.The text was updated successfully, but these errors were encountered: