Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclusive Cutoff Times #132

Open
jeff-hernandez opened this issue May 1, 2020 · 0 comments
Open

Exclusive Cutoff Times #132

jeff-hernandez opened this issue May 1, 2020 · 0 comments
Labels
bug Something isn't working enhancements Improvement to an existing feature

Comments

@jeff-hernandez
Copy link
Collaborator

jeff-hernandez commented May 1, 2020 •
edited

Data at cutoff times are currently inclusive in Featuretools and Compose. So, data leakage occurs since the same data point is used to calculate features as well as labels. This can be avoided by making the cutoff times (left endpoints) exclusive in data slices and right endpoints inclusive. It might be worth making this a parameter to provide more options by augmenting (not replacing) current functionality.
@jeff-hernandez jeff-hernandez added bug Something isn't working enhancements Improvement to an existing feature and removed bug Something isn't working labels May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancements Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jeff-hernandez